[d3d9] Spec-constant out writes to clip distances when disabled #4508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new spec constant with a mask of the enabled clip planes such that they can be optimized out to improve performance. For GPL shaders, override what we return here so it's always true and don't bother putting the mask in the UBO. Signed-off-by: Autumn Ashton <misyl@froggi.es>
misyltoad
force-pushed
the
misyl/spec-const-clip-plane
branch
2 times, most recently
from
9aa54b7 to
6870b62
Compare
DadSchoorse
reviewed
Dec 4, 2024
misyltoad
force-pushed
the
misyl/spec-const-clip-plane
branch
from
6870b62 to
296cb35
Compare
DadSchoorse
reviewed
Dec 4, 2024
misyltoad
force-pushed
the
misyl/spec-const-clip-plane
branch
from
296cb35 to
7c21717
Compare
DadSchoorse
reviewed
Dec 4, 2024
Compact clip planes to the smallest amount that are enabled. Signed-off-by: Autumn Ashton <misyl@froggi.es>
misyltoad
force-pushed
the
misyl/spec-const-clip-plane
branch
from
7c21717 to
f54964a
Compare
K0bin
approved these changes
Dec 4, 2024
temeraire-cx
pushed a commit
to chaotic-cx/mesa-mirror
that referenced
this pull request
Dec 10, 2024
This reduces the fixed function hardware bottleneck in vertex shading heavy sections with d3d9 DXVK. DXVK always declares 6 clip distances, and with doitsujin/dxvk#4508 it writes 0 for disabled clip planes. But while working on this, I also discovered that other games also write constant clip/cull distances: Foz-DB Navi21: Totals from 442 (0.56% of 79206) affected shaders: MaxWaves: 10880 -> 10900 (+0.18%) Instrs: 283569 -> 282493 (-0.38%); split: -0.38%, +0.01% CodeSize: 1497596 -> 1491948 (-0.38%); split: -0.38%, +0.00% VGPRs: 18928 -> 18888 (-0.21%) Outputs: 3026 -> 2970 (-1.85%) Latency: 1051990 -> 1048878 (-0.30%); split: -0.47%, +0.18% InvThroughput: 184190 -> 183366 (-0.45%); split: -0.45%, +0.01% VClause: 6071 -> 6077 (+0.10%); split: -0.38%, +0.48% SClause: 6724 -> 6725 (+0.01%); split: -0.12%, +0.13% Copies: 19624 -> 19160 (-2.36%); split: -2.44%, +0.08% PreSGPRs: 18634 -> 18526 (-0.58%) PreVGPRs: 15522 -> 15465 (-0.37%) VALU: 156964 -> 156330 (-0.40%); split: -0.41%, +0.01% SALU: 41802 -> 41748 (-0.13%); split: -0.13%, +0.00% Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32518>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new spec constant with a mask of the enabled clip planes such that they can be optimized out to improve performance.
For GPL shaders, override what we return here so it's always true and don't bother putting the mask in the UBO.