[d3d8/9] Clear pLockedRect/Box contents universally on lock

[WinterSnowfall]

Based on a test that I wrote and ran on Windows XP it looks like:

• d3d9 behaves similarly to d3d8 during LockRect/Box
• LockRect doesn't discriminate based on RTYPE and textures also get their pLockedRect contents cleared

So the Wine tests were partially incorrect for d3d8 and incomplete for d3d9 (the Wine test in question was d3d8 specific, in all fairness).

I'm waiting for @Blisto91 to confirm modern native behavior, and in the meantime I will do some general testing. Not that I expect anything to blow up due to this minor nit, but you never know.

Edit: All the above is confirmed on modern AMD and Intel Windows drivers.

[WinterSnowfall]

As tradition dictates, it appears the Wine d3d8 test was ultimately correct, and D3DRTYPE_TEXTURE surfaces don't get cleared... outside of D3DPOOL_DEFAULT. This API...

The behavior is however consistent between d3d8 and d3d9, that much still holds.

[WinterSnowfall]

Sigh... in the true spirit of d3d9, turns out there is a difference on LockRect. Anyway, it's all good now.

P.S.: @Blisto91 just confirmed the d3d9 test passes on Windows, so this seems fully inline with native now (famous last words).