Changes to support BTR using history api #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is failing as it requires a new release of webpack-contrib with the enhanced BTR support. The errors were previously being silenced due to the |
agubler
force-pushed
the
support-history-btr
branch
2 times, most recently
from
d3c15e8 to
1ae2b89
Compare
agubler
force-pushed
the
support-history-btr
branch
from
1ae2b89 to
2987157
Compare
agubler
commented
Nov 29, 2018
test-app/src/main.ts
Outdated
| @@ -12,6 +12,10 @@ import myTheme from './themes/test-app/theme'; | |||
|
|
|||
| console.log(myTheme); | |||
|
|
|||
| if (!exists('public-path')) { | |||
There was a problem hiding this comment.
This is temporary until the test-app can be upgraded to the 5.0.0-alpha of dojo/framework
Codecov Report
@@ Coverage Diff @@
## master #202 +/- ##
==========================================
- Coverage 53.83% 53.65% -0.19%
==========================================
Files 10 10
Lines 587 589 +2
Branches 143 143
==========================================
Hits 316 316
- Misses 271 273 +2
Continue to review full report at Codecov.
|
matt-gadd
approved these changes
Nov 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
prettierDescription:
Do not exit the process, so that BTR can run over multiple ticks and only generate chunk name if module text if found.
Related to dojo/webpack-contrib#87