This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 58
Adding base64 encoding from web-editor and removed old encoding #339
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
import global from './global'; | ||
import has, { add as hasAdd } from '@dojo/has/has'; | ||
|
||
hasAdd('btoa', 'btoa' in global); | ||
hasAdd('atob', 'atob' in global); | ||
|
||
/** | ||
* Take a string encoded in base64 and decode it | ||
* @param encodedString The base64 encoded string | ||
*/ | ||
export const decode: (encodedString: string) => string = has('atob') ? function (encodedString: string) { | ||
/* this allows for utf8 characters to be decoded properly */ | ||
return decodeURIComponent(Array.prototype.map.call(atob(encodedString), (char: string) => '%' + ('00' + char.charCodeAt(0).toString(16)).slice(-2)).join('')); | ||
} : function (encodedString: string): string { | ||
return new Buffer(encodedString.toString(), 'base64').toString('utf8'); | ||
}; | ||
|
||
/** | ||
* Take a string and encode it to base64 | ||
* @param rawString The string to encode | ||
*/ | ||
export const encode: (rawString: string) => string = has('btoa') ? function (decodedString: string) { | ||
/* this allows for utf8 characters to be encoded properly */ | ||
return btoa(encodeURIComponent(decodedString).replace(/%([0-9A-F]{2})/g, (match, code: string) => String.fromCharCode(Number('0x' + code)))); | ||
} : function (rawString: string): string { | ||
return new Buffer(rawString.toString(), 'utf8').toString('base64'); | ||
}; |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Essentially we are assuming that all supported browsers support
btob
/atob
, since the alternative is the Node-specificBuffer
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mwistrand yeah, and I think we are good on that account, https://caniuse.com/#search=atob . Supported back to IE 10.