Fix memory leaks from orphaned event listeners

dojo · Apr 18, 2020 · 32f8933 · 32f8933
1 parent 4eb5bc3
commit 32f8933
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/ColumnSet.js b/ColumnSet.js
@@ -371,7 +371,9 @@ define([
 					'.dgrid-column-set-scroller.dgrid-column-set-scroller-' + i +
 					'[' + colsetidAttr + '=' + i +']');
 			this._columnSetScrollerContents[i] = put(scroller, 'div.dgrid-column-set-scroller-content');
-			on(scroller, 'scroll', lang.hitch(this, '_onColumnSetScroll'));
+			this._listeners.push(
+				on(scroller, 'scroll', lang.hitch(this, '_onColumnSetScroll'))
+			);
 		},
 
 		_onColumnSetScroll: function (evt) {

diff --git a/Keyboard.js b/Keyboard.js
@@ -164,9 +164,11 @@ define([
 
 			if (this.tabableHeader) {
 				enableNavigation(this.headerNode);
-				on(this.headerNode, 'dgrid-cellfocusin', function () {
-					grid.scrollTo({ x: this.scrollLeft });
-				});
+				this._listeners.push(
+					on(this.headerNode, 'dgrid-cellfocusin', function () {
+						grid.scrollTo({ x: this.scrollLeft });
+					})
+				);
 			}
 			enableNavigation(this.contentNode);