Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autoSave: true breaks editor focus between cells #1298

Closed
stdavis opened this issue Aug 2, 2016 · 1 comment · Fixed by #1451
Closed

autoSave: true breaks editor focus between cells #1298

stdavis opened this issue Aug 2, 2016 · 1 comment · Fixed by #1451
Assignees
@msssk
Labels
bug

Comments

@stdavis
Copy link

stdavis commented Aug 2, 2016 •
edited
Loading

I'm having troubles when I edit a value in a cell and then try to move the focus to the next column.

Here's a stripped down example:

http://jsbin.com/sucakuf/11/edit?js,output
@stdavis
Copy link
Author

stdavis commented Aug 5, 2016

Update: It works if I change the editOn value from dgrid-cellfocusin to focus. Here's the change: http://jsbin.com/sucakuf/16/edit?js,output

So either this doc is wrong or there is a bug somewhere.

@msssk msssk added the bug label Mar 3, 2020
msssk added a commit to msssk/dgrid that referenced this issue Mar 3, 2020
@msssk
Keep track of focused editor cell so it persists after autosave
f0615a0 
Editor cells using 'dgrid-cellfocusin' trigger an edit of the newly focused
cell followed by a row save (if autosave is true). The save process destroys
the row, updates the data, and re-renders the row. The result is that the
newly rendered row is no longer focused. This PR keeps track of the focused
editor cell during the edit process so that when the save triggers a re-render
the editor is correctly re-activated and focused.

Fixes dojo#1298
@msssk msssk mentioned this issue Mar 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msssk msssk

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Keep track of focused editor cell so it persists after autosave msssk/dgrid
2 participants
@msssk @stdavis