Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When dragging multiple rows with the DnD extension dgrid can sometimes "lose" a row #1365

Closed
maier49 opened this issue Apr 25, 2017 · 2 comments
Closed

When dragging multiple rows with the DnD extension dgrid can sometimes "lose" a row #1365

maier49 opened this issue Apr 25, 2017 · 2 comments
Assignees
@edhager
Labels
bug

Comments

@maier49
Copy link
Contributor

maier49 commented Apr 25, 2017

In the linked JSFiddle, highlight rows 1 and 3, and then drag them below row 2. Row 3 will disappear

https://jsfiddle.net/46qL8ozo/1/
@maier49 maier49 added the bug label Apr 25, 2017
@edhager edhager self-assigned this Jun 1, 2017
@edhager edhager mentioned this issue Jun 1, 2017
Closed
@edhager
Copy link
Contributor

edhager commented Jun 1, 2017

This turned out to be a dstore bug: dojo/dojo1-dstore#207.

edhager added a commit to edhager/dgrid that referenced this issue Jun 1, 2017
@edhager
Add an efficiency to DnD that fixes a store problem.
8dc3dd5 
There is a dstore bug that appears when a put call uses the beforeId option and the beforeId matches the id of the item being updated.  This can occur when multiple rows that are not all siblings are moved via DnD.  See issue dojo#1365.
@edhager edhager mentioned this issue Jun 1, 2017
Merged
edhager added a commit that referenced this issue Jun 1, 2017
@edhager
Add an efficiency to DnD that fixes a store problem. (#1376)
cf21e54 
There is a dstore bug that appears when a put call uses the beforeId option and the beforeId matches the id of the item being updated.  This can occur when multiple rows that are not all siblings are moved via DnD.  See issue #1365.
@edhager edhager closed this as completed Jun 1, 2017
@edhager
Copy link
Contributor

edhager commented Jun 1, 2017

I created a dstore ticket to fix the issue in dstore but I also added a fix to dgrid. The dgrid fix will improve efficiency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edhager edhager

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edhager @maier49