Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dgrid/Grid updateSortArrow failing on IE caused by parentNode is null #1413

Closed
rmadiwalid opened this issue Feb 7, 2018 · 1 comment
Closed
Labels

Comments

@rmadiwalid
Copy link

rmadiwalid commented Feb 7, 2018

in dgrid/Grid class, when sorting on the dgrid on IE browser it's failing because of parentNode is null.
I can see that there was a change when migrated to dgrid 1.2.1.

if (this._lastSortedArrow) {
// Remove the sort classes from the parent node
domClass.remove(this._lastSortedArrow.parentNode, 'dgrid-sort-up dgrid-sort-down');
// Destroy the lastSortedArrow node
domConstruct.destroy(this._lastSortedArrow);
delete this._lastSortedArrow;
}

so I think we need a test on this line( in Grid.js class updateSortArrow method) to test that parentNode not null

domClass.remove(this._lastSortedArrow.parentNode

@dylans dylans added the bug label Feb 7, 2018
raykendo added a commit to raykendo/dgrid that referenced this issue Oct 31, 2018
Added check for whether this._lastArrowNode.parentNode is present before changing classes on it. Older IE versions may use parentElement property instead (IE6 or earlier)
dylans pushed a commit that referenced this issue Nov 5, 2018
Added check for whether this._lastArrowNode.parentNode is present before changing classes on it. Older IE versions may use parentElement property instead (IE6 or earlier)
@msssk
Copy link
Contributor

msssk commented Apr 3, 2020

Closing this as it was fixed in #1430

@msssk msssk closed this as completed Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants