Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Row/Cell) Selection not properly working on touch + mouse devices #757

Closed
bschultz opened this issue Oct 25, 2013 · 5 comments
Closed

(Row/Cell) Selection not properly working on touch + mouse devices #757

bschultz opened this issue Oct 25, 2013 · 5 comments

Comments

@bschultz
Copy link

When both touch and mouse are available (in this case, Chrome on a Windows 8 laptop with touchscreen), it is not possible to select an row with the mouse. Doing the same using touch it's working.

I have a listener for the "dgrid-select" and "dgrid-deselect" event, but it seems those events are not fired when using the mouse.

@kfranqueiro
Copy link
Member

Just to check, which version of dgrid are you trying this with? We actually heard a similar report recently and have introduced a fix in master which will be in the upcoming 0.3.12 release. You might want to pull the latest and see if that fixes it.

@bschultz
Copy link
Author

Version 0.3.11
Will try it with the master, thx.

@bschultz
Copy link
Author

My colleague said that the latest changes didn't fix it.
I haven't verified it yet.

But I guess the problem is with this code snippet:

if(has("touch") && !has("mspointer")){
        // listen for touch taps if available
        on(this.contentNode, touchUtil.selector(selector, touchUtil.tap), function(evt){
                grid._handleSelect(evt, this);
        });
}else{
        // listen for actions that should cause selections
        on(this.contentNode, on.selector(selector, this.selectionEvents), function(event){
                grid._handleSelect(event, this);
        });
}

Because the has("touch") is true it runs into the "if-part" and i guess the touchUtil can't handle mouse clicks.

@william-gr
Copy link

Hello!

This bug is affecting quite a few users in our application using dgrid. Can we put a milestone in this or does someone have a patch for this? Thank you very much!

@kfranqueiro
Copy link
Member

This is something we are hoping to address sometime this month for dgrid 0.3.14. #844 takes one approach at resolving it (and a few other touch+mouse issues) but its feature detect can result in some false negatives and positives so I plan to play with some other ideas.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants