Improved feature detection of touch scrolling #844
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that observable doesn't incorrectly determine if a page is at the end. refs
Conflicts: List.js test/JsonRest.html test/data/rest.php
|
I don't understand why this wasn't just kriszyp@33d59db. |
|
I'm wondering if your master branch has somehow diverged from SitePen/dgrid's... the last thing I see in your master branch is a merge commit, which seems wrong. I would suggest trying to rebase your master against SitePen/dgrid master, and then rebasing this branch against your master once it's fixed. Edit: Actually, I guess if something really diverged, rebasing is still going to leave your master in a state that's inconsistent from upstream. A hard reset may be necessary. Incidentally, I think one of the applications of this in your 2nd commit may help resolve #828, although I suspect it may also have the effect of disabling touch support for certain components. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't stand the broken scroll on my touch+mouse computer, so here is a possible fix.