Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift + row select highlights outside text (ie) #786

Closed
dayforcebonnie opened this issue Dec 4, 2013 · 4 comments
Closed

Shift + row select highlights outside text (ie) #786

dayforcebonnie opened this issue Dec 4, 2013 · 4 comments

Comments

@dayforcebonnie
Copy link

Using the shift key to select multiple rows in a grid in will also highlight text outside of the grid. Seems to only occur in any version of IE.
dtunedextrahighlightedtext

@kfranqueiro
Copy link
Member

This doesn't seem to happen to me in that demo. Which specific versions of IE did you try in? (I just tried in 9.) Can you provide reproduction steps?

@dayforcebonnie
Copy link
Author

Our QA found it in IE 10 and I was able to reproduce it in IE 11.

@brandonpayton
Copy link
Member

I can reproduce something like this by:

  1. Clicking a genre
  2. Clicking the song name column header while holding the shift key down
  3. Clicking a song row while holding the shift key down

@brandonpayton
Copy link
Member

Note: I forgot to add "while holding the shift key down" for step 3. Fixed now.

treasonx pushed a commit to treasonx/dgrid that referenced this issue Apr 29, 2014
ms-user-select: none; will block selection from starting on the element.
It will not block an existing selection from entering the element.

When using the shift modifier IE will select everything from the top of
the document, or last clicked location, up until the shift-clicked
location. Since the selection starts outside of the element marked with
ms-user-select: none; all of the text is selected.

Added a check for msUserSelect, and fallback to other methods to stop
selection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants