Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColumnHider Button Not Labeled #807

Closed
arias0906 opened this issue Jan 6, 2014 · 2 comments
Closed

ColumnHider Button Not Labeled #807

arias0906 opened this issue Jan 6, 2014 · 2 comments

Comments

@arias0906
Copy link

ColumnHider button is not labeled for screen readers. JAWS reads button as unlabeled. For accessibility, the i18nColumnHider.popupLabel should be applied to the button itself as well as an aria-label.

@kfranqueiro
Copy link
Member

Just to confirm, are you suggesting we add the popupLabel message as an aria-label on the menu trigger node in addition to the dialog itself which it is already on?

@arias0906
Copy link
Author

Essentially yes, the text contained in popupLabel would be perfect as an
aria-label on the columnhider button. Currently, the button is read by JAWS
as "unlabeled button" which does not give a user any information as to what
it does.

I would imagine it would probably be better to use another variable to hold
the button aria-label text. I kinda wrote the issue quickly and should have
been more clear.

Sorry for any confusion!
On Jan 10, 2014 3:15 PM, "Kenneth G. Franqueiro" notifications@github.com
wrote:

Just to confirm, are you suggesting we add the popupLabel message as an
aria-label on the menu trigger node in addition to the dialog itself which
it is already on?


Reply to this email directly or view it on GitHubhttps://github.com//issues/807#issuecomment-32061617
.

@ghost ghost closed this as completed in 7936b2f Aug 13, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants