ColumnSet + Tree: Scroll position of collapsed rows will fall out of sync #1137
Conversation
| @@ -182,6 +182,19 @@ define([ | |||
| this.on('.dgrid-column-set:dgrid-cellfocusin', function (event) { | |||
| self._onColumnSetCellFocus(event, this); | |||
| }); | |||
|
|
|||
| if ('expand' in this) { | |||
| aspect.after(this, 'expand', this.afterRowExpand, true); | |||
There was a problem hiding this comment.
I would probably vote for just including the function internally/anonymously here rather than separating it. It shouldn't be public, and even if we underscore-prefixed it, we'd want to pick a name that is unlikely to collide with something else. In this case, I don't think it's worth exposing.
|
We've been incrementally chipping away at issues with this PR, and while the actual fix works, the unit test doesn't fail when it should. Meanwhile, I've also now discovered that apparently the other ColumnSet unit tests previously written fail in IE/FF. These scroll-related unit tests are a real pain, and it seems we need to address them at a wider scale. |
|
To follow up on my previous comment, the other ColumnSet tests were only failing on master only, due to a naive implementation of a module to load the structural CSS for tests. Meanwhile, the new test was not failing when it should because it was not running the test's steps in the correct order (it was scrolling after re-expanding, not before). I've pushed a squashed commit of the updated fix + tests to master in 1122212 and dev-0.4 in 3354df6. |
These are the original steps to reproduce this bug:
This commit fixes this issue and provides a test