Fix a bug with keyboard navigation when there is no data #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns would cause an error on a grid with no data
dylans
approved these changes
Aug 13, 2018
msssk
pushed a commit
that referenced
this pull request
Apr 18, 2020
…ns would cause an error on a grid with no data (#1424)
msssk
pushed a commit
that referenced
this pull request
Apr 18, 2020
…ns would cause an error on a grid with no data (#1424)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Keyboard.js is mixed into a grid and the grid does not have any data, when the grid gets focus, using the up or down arrow keys, or the Page Up or Page Down buttons will cause an error and log it in the console window. I've created an example of this here: http://plnkr.co/edit/iI2TuSy5HnrhSmEqulED (open the F12 console to see the errors).
This should fix the issue by not trying to navigate if no node is focused.