Prevent unnecessary deselect/select when an already selected item is selected #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maier49
reviewed
Apr 6, 2020
| @@ -285,6 +285,12 @@ define([ | |||
| // except that clicks/keystrokes without modifier keys will clear | |||
| // the previous selection. | |||
|
|
|||
| // If the target is already selected, and is the sole selection, ignore a user action | |||
| // that would simply select the target (causing unnecessary deselect/select). | |||
| if (!event[ctrlEquiv] && this.isSelected(target) && this.getSelectedCount() === 1) { | |||
There was a problem hiding this comment.
On the line below where we're checking for the control key the logic used is
!(event.keyCode ? event.ctrlKey : event[ctrlEquiv])
Should we be replicating the same check here?
There was a problem hiding this comment.
I can't think of why that logic would be used anywhere. It only makes sense to me if:
- Mac browsers typically don't supply a value for
event.keyCode - There is a specific browser for which
has('mac')istrue, and that browser does supply a value forevent.keyCode, and instead ofevent.metaKeyit setsevent.ctrlKeywhen the Command key is pressed
I haven't found any discussion of ctrlKey/metaKey that justifies this logic. Am I missing something?
There was a problem hiding this comment.
You're right, I don't know of any situation where that makes sense.
maier49
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1011
When a selected row or cell is clicked on (or focused and spacebar pressed) dgrid will deselect it (and fire a deselect event) and re-select it (and fire a select event). This PR prevents the unnecessary deselect/select process.