Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reject handlers to query() calls in OnDemandList #242

Closed
wants to merge 1 commit into from
Closed

Add reject handlers to query() calls in OnDemandList #242

wants to merge 1 commit into from

Conversation

neekfenwick
Copy link

This was raised as #241

@ghost
Copy link

ghost commented Dec 19, 2012

This is actually just adding an error message as a child of the loading message div, which seems like it'd be awkward at best, and furthermore we've now fixed the code so that loading nodes are properly removed whether queries succeed or fail (see #351), so this code would now actually end up not showing anything.

See also my comment on #241 (comment)

@ghost ghost closed this Dec 19, 2012
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant