Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable to set formatter and editor on the same cell #497

Merged
merged 1 commit into from
Mar 26, 2013

Conversation

gratex
Copy link

@gratex gratex commented Mar 19, 2013

This enhancement makes possible to use formatter on editable cell too.
In previous implementation it was impossible, because when formatter was set on cell, renderCell method was always ignored.

In this enhancement we moved formatter resolving into our defaultRenderCell method.
This method is being called from Grid's renderRow and also from Editor's renderCell method, when Editor has property editOn set to "click" or "dblclick".

@kfranqueiro kfranqueiro merged commit ce06c38 into dojo:master Mar 26, 2013
@kfranqueiro
Copy link
Member

Thanks for this contribution - it's something that I'm kicking myself for not getting around to look at sooner. There was one subtle regression in behavior specifically involving formatters being (or not being) invoked on undefined values that I've tweaked the code a bit to remain consistent, and I've added cases to the editor and tree test pages to demonstrate the new functionality. I'll update the wiki shortly, since this was long documented as a limitation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants