Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DijitRegistry#getParent #538

Closed
wants to merge 1 commit into from
Closed

add DijitRegistry#getParent #538

wants to merge 1 commit into from

Conversation

k2s
Copy link
Contributor

@k2s k2s commented Apr 10, 2013

pls. add DijitRegistry#getParent for compatibility with dijit._KeyNavContainer

this is the code in dijit._KeyNavContainer

        childSelector: function(/*DOMNode*/ node){
            // Implement _KeyNavMixin.childSelector, to identify focusable child nodes.
            // If we allowed a dojo/query dependency from this module this could more simply be a string "> *"
            // instead of this function.

            var node = registry.byNode(node);
            return node && node.getParent() == this;
        }

Grid is received from registry, but it doesn't provide getParent(). Any _WidgetBase descendant would provide getParent().

@kfranqueiro
Copy link
Member

This has been merged in b2c5ef8. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants