Don't throw exception for large select ranges #799
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Selection can't currently handle large selection ranges because it drops nodes that are far away from the currently visible range. Emit a warning rather than throwing an exception when this happens. Fixes dojo#705 (sort of)
|
Fixed via e3fc0a2 for both Selection and CellSelection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Selection extension can't currently handle large selection ranges because it drops nodes that are far away from the currently visible range. Emit a warning rather than throwing an exception when this happens.
Fixes #705 (or at least mitigates it for now)