Fix _renderQueryParams #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combine filter queryLog entries in a manner which obeys order of precedence
edhager
force-pushed
the
master
branch
2 times, most recently
from
1dbb25d to
a5655fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have a Request store and you filter it with an OR operator and then later filter it with another filter the _renderQueryParams() method renders each filter from the queryLog separately. These rendered parameters are returned to _renderUrl() where they are joined together using the & symbol. No brackets are inserted around the OR term resulting in an incorrect request URL.
This fix combines 'filter' type queryLog entries in a manner which obeys order of precedence.