Fix trackable beforeId bug. #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maier49
approved these changes
Jun 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: the bug only affected a collection that did not have a query executor.
In Trackable on a put, the notify code removes the item from its tracking arrays and then tries to update the arrays with the item's new location. Before when the
beforeIdwas the item's id, the item was removed from the tracking arrays. When the code tried to add the item back to the tracking arrays, it was not added because the item referenced bybeforeIdwas not found.This fix recognizes when the
beforeIditem is removed and when the item is to be reinserted into the tracking arrays, it now follows the same path as an update without using thebeforeIdoption.Fix #207.