Update to exclusively use Intern 4 #162
Conversation
| @@ -1,5 +1,6 @@ | |||
| import * as registerSuite from 'intern!object'; | |||
| import * as assert from 'intern/chai!assert'; | |||
| const { registerSuite } = intern.getInterface('object'); | |||
There was a problem hiding this comment.
I might be noobing out, but do we need this anymore? I thought the fixSourceMaps task was only because of intern 3.
There was a problem hiding this comment.
You might be right. On these tasks, I did a 1:1 conversion without thinking if they needed removed.
There was a problem hiding this comment.
It turns out this task is to remove the path in the inline source maps rather than remapping the source maps, so it needs to stay
Codecov Report
@@ Coverage Diff @@
## master #162 +/- ##
===========================================
- Coverage 93.01% 69.56% -23.46%
===========================================
Files 16 27 +11
Lines 587 644 +57
Branches 0 102 +102
===========================================
- Hits 546 448 -98
- Misses 41 187 +146
- Partials 0 9 +9Continue to review full report at Codecov.
|
| "configs": { | ||
| "ci": { | ||
| "reporters": [ | ||
| { "name": "runner", "options": { "hidePassed": true, "hideSkipped": true } }, |
There was a problem hiding this comment.
Do we want to hideSkipped by default here?
Type: enhancement
The following has been addressed in the PR:
Description:
This PR updates the tasks to exclusively use Intern 4. The reporter has been converted to be loaded as an Intern 4 plugin. All PRs to convert projects to Intern 4 must be landed before this PR can be released in a new version.
Resolves #142