-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
Codecov Report
@@ Coverage Diff @@
## master #169 +/- ##
=========================================
+ Coverage 69.62% 70.53% +0.9%
=========================================
Files 27 28 +1
Lines 642 655 +13
Branches 102 104 +2
=========================================
+ Hits 447 462 +15
+ Misses 186 184 -2
Partials 9 9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No tests?
@kitsonk well... the test helper is loaded by intern so there isn't any coverage info for that. I can try to mock the global intern methods and then load the script from a test. Could get some coverage that way. Also.. it looks like the intern task doesn't have any tests right now 😛 With all that being said. I'm happy to add the tests if we want to put that additional time in as part of this PR. |
Tested this with |
"dojo-loader": "latest", | ||
"grunt": "^1.0.1", | ||
"istanbul-lib-instrument": "^1.9.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know that I technically need this as it is already loaded by intern...
Copying the custom loader from https://github.com/dojo/shim/pull/114/files#diff-f2f1547c4e267fa797af2b73e3456bd3R1 and injecting into the intern config automagically.
This loader loads the
@dojo/loader
, configures it with@dojo/shim/util/amd
and loads@dojo/shim/main
to load the TS helpers.This removes a bunch of boilerplate config from the other packages. Unfortunately this doesn't work when testing @dojo/shim, since the loader is different, so we have to provide a way to override the loader.