Don't leak global definitions where possible #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and declare them as var so they are not thought to be block scoped by TypeScript. Fixes dojo#154
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
==========================================
+ Coverage 84.98% 85.03% +0.05%
==========================================
Files 1 1
Lines 506 508 +2
Branches 133 133
==========================================
+ Hits 430 432 +2
Misses 32 32
Partials 44 44
Continue to review full report at Codecov.
|
dylans
approved these changes
Feb 26, 2018
rorticus
approved these changes
Mar 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
Description:
Don't leak global definitions where possible and declare them as var so they are not thought to be block scoped by TypeScript.
Resolves #154