Fix how global define is unset #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`define` was just a local variable. Actually unset the global `define` when requiring a Node module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
definewas just a local variable. Actually unset the globaldefinewhen requiring a Node module.Looks like there was no test for this behavior. I'd add it but not quite sure where to start.
This fixes
TypeError: ESP.parse is not a functionoutput in test runs, see this Travis build for an example. In this case Intern uses loader to load a custom reporter, which then requiresistanbul/lib/instrumenter. This module requiresesprimawhich erroneously selects the AMD loader.