Skip to content
This repository has been archived by the owner on Jul 30, 2018. It is now read-only.

Global cleanup #61

Closed
dylans opened this issue Dec 5, 2016 · 3 comments
Closed

Global cleanup #61

dylans opened this issue Dec 5, 2016 · 3 comments
Assignees
Labels
Milestone

Comments

@dylans
Copy link
Member

dylans commented Dec 5, 2016

Per #56 (comment) :

  • There's a global implementation in shim and a different one in dojo/core. Should the one in core be removed and usage of it replaced with this one?
  • What happens with this global implementation is csp prevents unsafe eval?
@dylans dylans added this to the 2016.12 milestone Dec 5, 2016
@dylans dylans modified the milestones: 2017.01, 2016.12 Dec 21, 2016
@eheasley eheasley modified the milestones: 2017.02, 2017.01 Jan 24, 2017
@dylans dylans modified the milestones: 2017.02, 2017.03 Mar 1, 2017
@kitsonk
Copy link
Member

kitsonk commented Mar 8, 2017

The one in dojo/core should be removed. Previously, there wasn't a "home" because it was non-standard. Now that it is part of a formal proposal, it belongs in shim and should be removed from everywhere else.

@kitsonk
Copy link
Member

kitsonk commented Mar 8, 2017

Also, related to this, we should move it from support/global.ts to global.ts as it is aligned to the ES proposal.

@kitsonk
Copy link
Member

kitsonk commented Mar 8, 2017

As far as the second point, yes, that was the "old" way of doing global, and then in core we updated it with something that would work well with CSP, only to have missed it in support. 🤷‍♂️

@kitsonk kitsonk self-assigned this Mar 9, 2017
@kitsonk kitsonk added the bug label Mar 9, 2017
@dylans dylans modified the milestones: 2017.03, 2017.04 Apr 2, 2017
@dylans dylans modified the milestones: 2017.04, 2017.05 Apr 29, 2017
@eheasley eheasley modified the milestones: 2017.05, 2017.06 Jun 6, 2017
kitsonk added a commit that referenced this issue Jun 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants