This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
JSON merge patch #80
Closed
JSON merge patch #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
======================================
Coverage 100% 100%
======================================
Files 15 17 +2
Lines 1096 1239 +143
Branches 185 216 +31
======================================
+ Hits 1096 1239 +143
Continue to review full report at Codecov.
|
* Split a separate BaseStorage * Move non InMemory specific interfaces into BaseStorage for reuse. Initial version of Rest Storage. Implement patch APIs. Implement fetch API. Add unit tests for most rest operations. Fix issues found. Add unit tests for fetch and patch. Clean up and refactoring. Add initPromise errors out scenario, bring coverages to 100%. Add missing WeakMap and switch `dojo-shim/array#find` Feedback changes. - Make `idSerializer` not default to a built in one, and add the ability to send multiple GET/DELETE requests when it is not in the option. - Add the option `customPutPostRequest` with the ability to send multiple PUT/POST requests. - Update/Add unit tests accordingly. Feedback changes. Add needed export for dist and use mixin object structure instead of compsoe factories
maier49
force-pushed
the
json-merge-patch
branch
from
2441b4d to
176d5d5
Compare
rorticus
approved these changes
Jan 11, 2017
| import WeakMap from 'dojo-shim/WeakMap'; | ||
| import Map from 'dojo-shim/Map'; | ||
| import { Patch } from '../patch/createPatch'; | ||
| import WeakMap from 'dojo-shim/WeakMap'; |
There was a problem hiding this comment.
This probably isn't supposed to be indented?
|
Closing because this is out of date and this functionality is now included in #124 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
Description:
This builds off of #48 , resolving the TODOs there with regards to JSON Merge Patch. This adds a
toMergeStringmethod to thePatchinterface that produces a JSON Merge Patch compliant string when possible. Some JSON Patch operations are not really supported by the JSON Merge Patch format, but those operations are also not produced by thedifffunctionality provided in stores so under normal circumstances any patch sent by REST storage will be valid.This PR adds onto #48 with only these changes so it could be merged after or instead of it.
Related Issue: #47 , #4
Please review this checklist before submitting your PR: