Fix: Ensure all css is written and deduped correctly in BTR #106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
prettier
as per the readme code style guidelinesDescription:
The existing BTR uses some rudimentary logic to try and avoid writing duplicate CSS to the
index.html
file(s). However there are multiple edge cases where this is not good enough and we end up not writing CSS selectors that are required.This change removes this logic and replaces it will a post processing phase using
postcss
andcssnano
to correctly optimise the styles prior to writing them to theindex.html