Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Ensure all css is written and deduped correctly in BTR #106

Merged
merged 3 commits into from
Dec 21, 2018

Conversation

agubler
Copy link
Member

@agubler agubler commented Dec 21, 2018

Type: bug

The following has been addressed in the PR:

Description:

The existing BTR uses some rudimentary logic to try and avoid writing duplicate CSS to the index.html file(s). However there are multiple edge cases where this is not good enough and we end up not writing CSS selectors that are required.

This change removes this logic and replaces it will a post processing phase using postcss and cssnano to correctly optimise the styles prior to writing them to the index.html

@agubler agubler changed the title Fix: Ensure all css is written and deduped correctly Fix: Ensure all css is written and deduped correctly in BTR Dec 21, 2018
@codecov
Copy link

codecov bot commented Dec 21, 2018

Codecov Report

Merging #106 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
- Coverage   84.05%   84.02%   -0.03%     
==========================================
  Files          37       37              
  Lines        1392     1390       -2     
  Branches      373      372       -1     
==========================================
- Hits         1170     1168       -2     
  Misses        222      222
Impacted Files Coverage Δ
src/build-time-render/BuildTimeRender.ts 98.15% <100%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3db46bb...8ee7a77. Read the comment docs.

@agubler agubler merged commit 85ee025 into dojo:master Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants