Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statically render routes using build time rendering #88

Closed
wants to merge 10 commits into from

Conversation

agubler
Copy link
Member

@agubler agubler commented Nov 7, 2018

Type: feature

The following has been addressed in the PR:

Description:

Statically render index.html for build time rendering paths when using the history API (StateHistory) routing in the application.

Resolves #87

@codecov
Copy link

codecov bot commented Nov 7, 2018

Codecov Report

Merging #88 into master will increase coverage by 0.4%.
The diff coverage is 98.3%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #88     +/-   ##
=========================================
+ Coverage   84.54%   84.95%   +0.4%     
=========================================
  Files          33       33             
  Lines        1171     1216     +45     
  Branches      321      331     +10     
=========================================
+ Hits          990     1033     +43     
- Misses        181      183      +2
Impacted Files Coverage Δ
src/build-time-render/BuildTimeRender.ts 100% <100%> (ø) ⬆️
src/build-time-render/hasBuildTimeRender.ts 71.42% <60%> (-28.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a87b88...4bdfbef. Read the comment docs.

@agubler
Copy link
Member Author

agubler commented Nov 9, 2018

closing in favour of #91

@agubler agubler closed this Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant