Upgrade webpack to v4 #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
==========================================
+ Coverage 85.43% 85.49% +0.05%
==========================================
Files 33 33
Lines 1270 1275 +5
Branches 356 356
==========================================
+ Hits 1085 1090 +5
Misses 185 185
Continue to review full report at Codecov.
|
3 tasks
mwistrand
force-pushed
the
upgrade-webpack-v4
branch
from
7c36361 to
70b5f61
Compare
- Update loaders and plugins to use the updated webpack interfaces - Update webpack typings and remove unused typings - Update unit tests - Remove webpack mocks in favor of the actual classes
mwistrand
force-pushed
the
upgrade-webpack-v4
branch
from
70b5f61 to
535b7de
Compare
matt-gadd
approved these changes
Nov 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
Update functionality to webpack v4 interfaces. Verified on Mac and Windows with multiple test applications.