Skip to content
This repository has been archived by the owner on Jul 30, 2018. It is now read-only.

Support original afterRenders when replacing render with an Injector #601

Merged
merged 2 commits into from
Jun 28, 2017

Conversation

agubler
Copy link
Member

@agubler agubler commented Jun 27, 2017

Type: bug

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:
Further support in WidgetBase and Injector to enable correct afterRenders to be executed when the original DNodes are returned from the render function passed to the Injector.

Breaking change as updated this.registries to this.getRegistries() so that Injector can override and call the super.getRegistries() with the original widgets scope passed as the properties.

Resolves #600

@agubler
Copy link
Member Author

agubler commented Jun 27, 2017

Weird codecov issues.

@agubler agubler closed this Jun 27, 2017
@agubler agubler reopened this Jun 27, 2017
@agubler agubler mentioned this pull request Jun 27, 2017
3 tasks
@agubler agubler merged commit 7b2a1bd into dojo:master Jun 28, 2017
@dylans dylans added this to the 2017.06 milestone Jul 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants