Skip to content
This repository has been archived by the owner on Jul 30, 2018. It is now read-only.

Fix Edge failures #680

Merged
merged 7 commits into from
Sep 15, 2017
Merged

Fix Edge failures #680

merged 7 commits into from
Sep 15, 2017

Conversation

tomdye
Copy link
Member

@tomdye tomdye commented Sep 14, 2017

Type: bug

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:

Fixes edge failures. Makes certain tests sync

Resolves #679

@@ -193,6 +193,8 @@ export class WidgetBase<P = WidgetProperties, C extends DNode = DNode> extends E

private _numRootNodes = 0;

private _rootNodeKeys: object[];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is a root node key really an object?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a typing error when i set it to string[]. The typedoc popup said that properties.key is an object.
screenshot 2017-09-15 09 44 15

@tomdye tomdye merged commit 16d1d33 into dojo:master Sep 15, 2017
@dylans dylans added this to the 2017.09 milestone Sep 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants