This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
Do not ignore package-lock.json #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitsonk
approved these changes
Oct 9, 2017
|
Probably should also open an issue on meta for this so we can roll it out everywhere. |
dylans
approved these changes
Oct 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
Description:
We shouldn't need to ignore the package-lock.json anymore, it causes a failure in the
grunt releasetask as it is usingnpm versionwhich implicitly tries to add the file to commit (and the release fails). As the peer dependencies are installed with a pre publish script we should always get the latest version according to the semver dependency version.