Skip to content
This repository has been archived by the owner on Jul 30, 2018. It is now read-only.

Only merge on initial render #739

Merged
merged 3 commits into from
Nov 3, 2017
Merged

Only merge on initial render #739

merged 3 commits into from
Nov 3, 2017

Conversation

agubler
Copy link
Member

@agubler agubler commented Nov 2, 2017

Type: bug

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:

Only merge onto an existing DOM structure for the initial render

Resolves #738

@codecov
Copy link

codecov bot commented Nov 2, 2017

Codecov Report

Merging #739 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #739      +/-   ##
==========================================
+ Coverage   98.42%   98.42%   +<.01%     
==========================================
  Files          30       30              
  Lines        1520     1521       +1     
  Branches      298      298              
==========================================
+ Hits         1496     1497       +1     
  Misses          7        7              
  Partials       17       17
Impacted Files Coverage Δ
src/vdom.ts 99.56% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bbf5a8...3a9fafa. Read the comment docs.

@codecov
Copy link

codecov bot commented Nov 2, 2017

Codecov Report

Merging #739 into master will decrease coverage by 0.26%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #739      +/-   ##
==========================================
- Coverage   98.42%   98.16%   -0.27%     
==========================================
  Files          30       30              
  Lines        1520     1522       +2     
  Branches      298      302       +4     
==========================================
- Hits         1496     1494       -2     
- Misses          7       10       +3     
- Partials       17       18       +1
Impacted Files Coverage Δ
src/vdom.ts 99.55% <100%> (-0.02%) ⬇️
src/mixins/Projector.ts 95.03% <0%> (-2.7%) ⬇️
src/mixins/Themed.ts 97.18% <0%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bbf5a8...3a9fafa. Read the comment docs.

@agubler agubler requested review from kitsonk and matt-gadd November 2, 2017 16:03
@matt-gadd
Copy link
Contributor

matt-gadd commented Nov 3, 2017

lots of test changes for a 1 line change 😄

@kitsonk
Copy link
Member

kitsonk commented Nov 3, 2017

I was thinking the same thing! 😂

@agubler
Copy link
Member Author

agubler commented Nov 3, 2017

There is one new one hidden in there... honest! Silly idea to create a test group for merging 🙈

@agubler agubler merged commit bab9dd8 into dojo:master Nov 3, 2017
@dylans dylans added this to the beta.4 milestone Nov 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants