This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
Tidy up consistency for singular and multiple classes #740
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
Description:
The typings for a singular classname did not support
null
, while the multiple variance did inThemed
. InVirtualDomProperties
classes
supportednull
across both, but the array version supportedundefined
also. The typings are now consistent across everything.Functionally, passing
null
in an array tothis.theme
filtered it, while passingnull
singularly would log a warning. The functionality is now to not warn or filter consistently across both, as the filtering is done invdom
anyway.