This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
Skip the main set properties logic for the initial properties set #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitsonk
reviewed
Nov 9, 2017
| const registeredDiffPropertyNames = this.getDecorator('registeredDiffProperty'); | ||
| let runReactions = false; | ||
| const changedPropertyKeys: string[] = []; | ||
| const propertyNames = Object.keys(properties); |
There was a problem hiding this comment.
just a reminder that on IE11 and any properties that are symbols, they will come back with Object.keys. I don't know if you need symbol safe Object.keys here or not.
There was a problem hiding this comment.
We already used Object.keys within __setProperties__ to get the property names, so this hasn't really changed (i just hoisted it, so I could share)
kitsonk
approved these changes
Nov 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
Description:
Simplify the set properties logic for the initial set properties
Resolves #762