refactor(katana): replace cursor-based api with by block basis for simplicity

[kariy]

Description

currently, the saya_getTransactionsExecutions API is based on a cursor to determine how the traces are being fetched.

dojo/crates/saya/provider/src/rpc/mod.rs

Lines 160 to 175 in 855da31

	trace!(target: LOG_TARGET, block_number = %block_number, "Fetching transactions executions.");
	let cursor = TransactionsPageCursor { block_number, chunk_size: 50, ..Default::default() };
	let client = HttpClientBuilder::default().build(&self.rpc_url).unwrap();
	let mut executions = vec![];
	loop {
	let rsp: TransactionsExecutionsPage =
	client.get_transactions_executions(cursor).await.unwrap();
	executions.extend(rsp.transactions_executions);
	if rsp.cursor.block_number > block_number {
	break;
	}
	}

one issue it currently has it that the api params does not put any constraint on whether the returned traces are guarantee to only be from a specific block. however, the implementation seems to indicate otherwise.

anyway, this pr basically want to remove the complexity of the pagination logic (which we dont even need!) and to replace it with a basic get Xs from block Y api instead.

so we can simplify the endpoint itself to just return the traces per block instead of based on a cursor. the cursor is only adding more complexity to the api itself.

Related issue

Tests

• Yes
• No, because they aren't needed
• No, because I need help

Added to documentation?

• README.md
• Dojo Book
• No documentation needed

Checklist

• I've formatted my code (scripts/prettier.sh, scripts/rust_fmt.sh, scripts/cairo_fmt.sh)
• I've linted my code (scripts/clippy.sh, scripts/docs.sh)
• I've commented my code
• I've requested a review after addressing the comments

[kariy]

• fix(katana): l1/l2 messaging hash computations #1981
• Add doc comments for L1HandlerTx #1980
• Refactor saya to fetch the traces using the new API #1987
• refactor(katana): replace cursor-based api with by block basis for simplicity #1986 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kariy and the rest of your teammates on Graphite

[codecov]

Codecov Report

Attention: Patch coverage is 94.17476% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 69.84%. Comparing base (bec687b) to head (e693598).
Report is 1 commits behind head on main.

Files	Patch %	Lines
crates/katana/storage/provider/src/lib.rs	37.50%	5 Missing ⚠️
crates/katana/rpc/rpc/src/saya.rs	97.82%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1986      +/-   ##
==========================================
+ Coverage   69.73%   69.84%   +0.10%     
==========================================
  Files         314      314              
  Lines       35654    35726      +72     
==========================================
+ Hits        24864    24953      +89     
+ Misses      10790    10773      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kariy]

Merge activity

• May 23, 9:16 AM EDT: @kariy started a stack merge that includes this pull request via Graphite.
• May 23, 9:16 AM EDT: @kariy merged this pull request with Graphite.