Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Dockerfile): add Tini init system for better process management #2459

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

steebchen
Copy link
Contributor

@steebchen steebchen commented Sep 20, 2024

Description

  • Added Tini version v0.19.0
  • Configured ENTRYPOINT to use Tini

This fixes proper signal handling in docker.

Related issue

Tests

  • Yes
  • No, because they aren't needed
  • No, because I need help

Added to documentation?

  • README.md
  • Dojo Book
  • No documentation needed

Checklist

  • I've formatted my code (scripts/prettier.sh, scripts/rust_fmt.sh, scripts/cairo_fmt.sh)
  • I've linted my code (scripts/clippy.sh, scripts/docs.sh)
  • I've commented my code
  • I've requested a review after addressing the comments

Summary by CodeRabbit

  • New Features

    • Enhanced container initialization process by integrating Tini, improving reliability and performance.
    • Added an environment variable to specify the Tini version.
  • Bug Fixes

    • Updated permissions for the Tini binary to ensure it is executable.

- Added Tini version v0.19.0
- Configured ENTRYPOINT to use Tini
Copy link

coderabbitai bot commented Sep 20, 2024

Walkthrough

Ohayo, sensei! The Dockerfile has been updated to incorporate Tini, a minimal init system for Docker containers. Key modifications include defining an environment variable for Tini's version, downloading the Tini binary, setting its permissions to executable, and updating the entry point of the container to utilize Tini. These changes streamline the container's initialization process.

Changes

File Change Summary
Dockerfile - Added environment variable TINI_VERSION with value v0.19.0.
- Downloaded Tini binary from GitHub and added to root directory.
- Set permissions of Tini binary to executable.
- Updated entry point to use Tini with ENTRYPOINT ["/tini", "--"].

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8b7d6b2 and 1594739.

Files selected for processing (1)
  • Dockerfile (1 hunks)
Additional comments not posted (1)
Dockerfile (1)

19-22: Ohayo sensei! The Tini integration looks solid.

Adding Tini as the init system is a great move. It will properly handle signals and reap zombie processes, improving the stability and reliability of our containerized application. The implementation looks clean and follows best practices.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.31%. Comparing base (8b7d6b2) to head (1594739).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2459   +/-   ##
=======================================
  Coverage   68.31%   68.31%           
=======================================
  Files         365      365           
  Lines       48034    48034           
=======================================
  Hits        32813    32813           
  Misses      15221    15221           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glihm glihm merged commit 0d08411 into main Sep 22, 2024
16 checks passed
@glihm glihm deleted the feat/docker-tini branch September 22, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants