-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Dockerfile): add Tini init system for better process management #2459
Conversation
- Added Tini version v0.19.0 - Configured ENTRYPOINT to use Tini
WalkthroughOhayo, sensei! The Dockerfile has been updated to incorporate Tini, a minimal init system for Docker containers. Key modifications include defining an environment variable for Tini's version, downloading the Tini binary, setting its permissions to executable, and updating the entry point of the container to utilize Tini. These changes streamline the container's initialization process. Changes
Recent review detailsConfiguration used: .coderabbit.yaml Files selected for processing (1)
Additional comments not posted (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2459 +/- ##
=======================================
Coverage 68.31% 68.31%
=======================================
Files 365 365
Lines 48034 48034
=======================================
Hits 32813 32813
Misses 15221 15221 ☔ View full report in Codecov by Sentry. |
Description
This fixes proper signal handling in docker.
Related issue
Tests
Added to documentation?
Checklist
scripts/prettier.sh
,scripts/rust_fmt.sh
,scripts/cairo_fmt.sh
)scripts/clippy.sh
,scripts/docs.sh
)Summary by CodeRabbit
New Features
Bug Fixes