-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(katana): remove events trace log #2570
Conversation
WalkthroughOhayo, sensei! The recent changes to the Katana executor involve significant updates to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant BlockifierFactory
participant StarknetVMProcessor
participant ExecutorExt
User->>BlockifierFactory: create new instance
BlockifierFactory->>StarknetVMProcessor: configure and initialize
StarknetVMProcessor->>ExecutorExt: execute transactions
ExecutorExt->>StarknetVMProcessor: simulate transactions
StarknetVMProcessor->>User: return execution results
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2570 +/- ##
==========================================
- Coverage 69.80% 69.76% -0.04%
==========================================
Files 401 401
Lines 51179 51172 -7
==========================================
- Hits 35723 35702 -21
- Misses 15456 15470 +14 ☔ View full report in Codecov by Sentry. |
this remove the
trace!
log for transaction events that is emitted after the execution of every transaction.for transaction that emits a lot of event (definitely yes, in the case of dojo application) the logs are being emitted are too much. and afaik most people dont even find it particularly THAT useful.
below is an example of the events log from the Dojo example project:
not sure who is autistic enough (too bad im not) to even find these logs useful. maybe useful in the case of identifying the transactions based on the number of events (or a specific event hash) but in most scenario, these logs are ignored. emitting these logs however, (especially when there are a lot of events) are not free, they takes a some amount of resources, and in the case of Slot, storing these logs takes up most of the storage capacity.
Summary by CodeRabbit
New Features
BlockifierFactory
for enhanced configuration and simulation of blockchain transactions.Bug Fixes
Chores
log_events
function, streamlining event logging processes.