-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use now as timestamp for delta calc for pending blocks #2586
Conversation
WalkthroughOhayo, sensei! The changes in this pull request focus on modifying the Changes
Sequence Diagram(s)sequenceDiagram
participant Executor
participant Cursor
participant Time
Executor->>Cursor: Handle UpdateCursorsQuery
Cursor-->>Executor: Return current timestamp
alt New timestamp differs
Executor->>Time: Capture current time
Time-->>Executor: Return elapsed time
Executor->>Executor: Calculate TPS
else New timestamp is the same
Executor->>Time: Capture current time
Time-->>Executor: Return elapsed time
Executor->>Executor: Use elapsed time for TPS calculation
end
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2586 +/- ##
==========================================
+ Coverage 69.57% 69.66% +0.09%
==========================================
Files 401 401
Lines 50848 50819 -29
==========================================
+ Hits 35378 35404 +26
+ Misses 15470 15415 -55 ☔ View full report in Codecov by Sentry. |
Summary by CodeRabbit
New Features
Bug Fixes