Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use now as timestamp for delta calc for pending blocks #2586

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

Larkooo
Copy link
Collaborator

@Larkooo Larkooo commented Oct 28, 2024

Summary by CodeRabbit

  • New Features

    • Improved transaction per second (TPS) calculation for cursor updates, enhancing performance reliability.
  • Bug Fixes

    • Introduced a fallback mechanism to prevent division by zero in TPS calculations.

Copy link

coderabbitai bot commented Oct 28, 2024

Walkthrough

Ohayo, sensei! The changes in this pull request focus on modifying the UpdateCursorsQuery handling within the Executor struct. The handle_query_type method has been updated to enhance the calculation of transactions per second (TPS). A fallback mechanism is introduced to handle cases where the new timestamp matches the cursor's timestamp, ensuring that TPS can still be calculated without running into division by zero errors. The error handling and logging remain unchanged, maintaining the overall structure of the Executor class.

Changes

File Path Change Summary
crates/torii/core/src/executor.rs Modified handle_query_type method in Executor to enhance TPS calculation logic with a fallback mechanism.

Sequence Diagram(s)

sequenceDiagram
    participant Executor
    participant Cursor
    participant Time

    Executor->>Cursor: Handle UpdateCursorsQuery
    Cursor-->>Executor: Return current timestamp
    alt New timestamp differs
        Executor->>Time: Capture current time
        Time-->>Executor: Return elapsed time
        Executor->>Executor: Calculate TPS
    else New timestamp is the same
        Executor->>Time: Capture current time
        Time-->>Executor: Return elapsed time
        Executor->>Executor: Use elapsed time for TPS calculation
    end
Loading

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between ef696ea and 6790397.

📒 Files selected for processing (1)
  • crates/torii/core/src/executor.rs (1 hunks)

crates/torii/core/src/executor.rs Show resolved Hide resolved
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.66%. Comparing base (ef696ea) to head (6790397).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
crates/torii/core/src/executor.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2586      +/-   ##
==========================================
+ Coverage   69.57%   69.66%   +0.09%     
==========================================
  Files         401      401              
  Lines       50848    50819      -29     
==========================================
+ Hits        35378    35404      +26     
+ Misses      15470    15415      -55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glihm glihm merged commit 05fb95b into dojoengine:main Nov 1, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants