chore(devcontainer): update image: v1.0.8 #2815
Conversation
WalkthroughOhayo, sensei! This pull request focuses on updating the Docker image version from Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/ci.yml (2)
Line range hint
184-203: Ohayo sensei! Nice addition of API testing with HurlThe new test-hurl job is well structured with proper setup of dependencies and test execution. Consider adding a comment to document the purpose of these API tests.
test-hurl: + # Executes API integration tests using Hurl to validate RPC endpoints needs: build runs-on: ubuntu-latest🧰 Tools
🪛 actionlint (1.7.4)
32-32: label "ubuntu-latest-32-cores" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
36-36: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
Line range hint
95-104: Consider enhancing error diagnostics, senseiThe katana process verification is a good addition, but we could capture more diagnostic information when it fails.
./katana & KATANA_PID=$! sleep 2 if ! kill -0 $KATANA_PID; then - echo "Katana exited with an error" + echo "Katana process (PID: $KATANA_PID) exited unexpectedly" + echo "Last few lines of katana output:" + tail -n 10 katana.log exit 1 fi kill $KATANA_PID🧰 Tools
🪛 actionlint (1.7.4)
32-32: label "ubuntu-latest-32-cores" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
36-36: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.devcontainer/devcontainer.json(1 hunks).github/workflows/bench.yml(2 hunks).github/workflows/ci.yml(7 hunks).github/workflows/release-dispatch.yml(1 hunks)
✅ Files skipped from review due to trivial changes (3)
- .github/workflows/bench.yml
- .github/workflows/release-dispatch.yml
- .devcontainer/devcontainer.json
🔇 Additional comments (1)
.github/workflows/ci.yml (1)
34-34: Ohayo! Verify the changelog for dojo-dev:v1.0.8
The Docker image version has been consistently updated across all jobs. Let's verify the changes in this version.
Also applies to: 59-59, 126-126, 142-142, 157-157, 166-166, 175-175
✅ Verification successful
Ohayo! The Docker image version v1.0.8 is verified and up-to-date, sensei!
The version update is appropriate as v1.0.8 is the latest release (published on December 16, 2024) with verified changes including:
- Torii gRPC query improvements
- Entity timestamp tracking updates
- Proper version progression from v1.0.7
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check the latest version and changelog of dojo-dev image
# Check latest version tag
gh api \
-H "Accept: application/vnd.github+json" \
repos/dojoengine/dojo/packages/container/dojo-dev/versions \
--jq '.[0].metadata.container.tags[0]'
# Check for changelog or release notes
gh release view v1.0.8 --repo dojoengine/dojo 2>/dev/null || echo "No release notes found for v1.0.8"
Length of output: 1452
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2815 +/- ##
==========================================
- Coverage 55.67% 55.67% -0.01%
==========================================
Files 439 439
Lines 55699 55699
==========================================
- Hits 31009 31008 -1
- Misses 24690 24691 +1 ☔ View full report in Codecov by Sentry. |
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
New Features
v1.0.8across various workflows and development environments.testjob to download artifacts and set executable permissions.test-hurljob for running tests against.hurlfiles.ensure-dockerjob to monitor thekatanaprocess.Bug Fixes
katanaprocess with error messaging for unexpected exits.