Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Добавляет рецепт c прямоугольником, собачкой и лабиринтом #5244

Merged
merged 23 commits into from
Apr 12, 2024
Merged

Добавляет рецепт c прямоугольником, собачкой и лабиринтом #5244

merged 23 commits into from
Apr 12, 2024

Conversation

HellSquirrel
Copy link
Member

@HellSquirrel HellSquirrel commented Apr 1, 2024 •
edited
Loading

Добавляет продолжение рецепта про React компоненты. На этот раз на клиенте

@github-actions github-actions bot added статья Расширенный материал рецепт Контент для Рецептов labels Apr 1, 2024
solarrust
solarrust reviewed Apr 3, 2024
View reviewed changes
Copy link
Member

@solarrust solarrust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐶🎾🔲

recipes/expressive-react-maze/index.md Outdated Show resolved Hide resolved
recipes/expressive-react-maze/index.md Outdated Show resolved Hide resolved
recipes/expressive-react-maze/index.md Outdated Show resolved Hide resolved
recipes/expressive-react-maze/index.md Outdated Show resolved Hide resolved
recipes/expressive-react-maze/index.md Outdated Show resolved Hide resolved
recipes/expressive-react-maze/index.md Outdated Show resolved Hide resolved
recipes/expressive-react-maze/index.md Outdated Show resolved Hide resolved
recipes/expressive-react-maze/index.md Outdated Show resolved Hide resolved
recipes/expressive-react-maze/index.md Outdated Show resolved Hide resolved
recipes/expressive-react-rectangle/index.md Outdated Show resolved Hide resolved
@HellSquirrel
Copy link
Member Author

Фух, все. Черновик закончен. Я мучительно правлю форматирование и украшаю демку. Теперь можно посмотреть :) Предыдущие комменты в процессе резолва

@HellSquirrel HellSquirrel marked this pull request as ready for review April 8, 2024 23:04
HellSquirrel and others added 2 commits April 9, 2024 03:07
@HellSquirrel @solarrust
Принимает правки
0b739cd 
Co-authored-by: Alena Batitskaia <solarrust@users.noreply.github.com>
@HellSquirrel
Возвращает картинку у null
7ebe14c
@HellSquirrel HellSquirrel force-pushed the recipe/expressive-react-2-maze branch from 9f87567 to 7ebe14c Compare April 8, 2024 23:09
@vitya-ne
Copy link
Contributor

vitya-ne commented Apr 12, 2024 •
edited
Loading

Кидай саджесты..

у меня для них каких-то прав не хватает )

готово. нашёл пару опечаток и добавил пару коментов.

@HellSquirrel
Copy link
Member Author

Эмейзинг! Сча все поправлю

@HellSquirrel
Copy link
Member Author

HellSquirrel commented Apr 12, 2024 •
edited
Loading

С демкой ничего не будем делать?

Давай пока неть. Если что демка вот тут сидит https://github.com/HellSquirrel/expressive-react-maze

@HellSquirrel
Copy link
Member Author

@TatianaFokina вернула собачку на строку выше, а то не очень понятно что оно значит. Но в целом коменты после кода - норм

@vitya-ne
Copy link
Contributor

@HellSquirrel вроде всё. две мелочи только

@HellSquirrel
Copy link
Member Author

Спасибище!

TatianaFokina
TatianaFokina approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@TatianaFokina TatianaFokina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Докинула запятых

recipes/expressive-react-maze/index.md Outdated Show resolved Hide resolved
recipes/expressive-react-maze/index.md Outdated Show resolved Hide resolved
recipes/expressive-react-maze/index.md Outdated Show resolved Hide resolved
recipes/expressive-react-maze/index.md Outdated Show resolved Hide resolved
recipes/expressive-react-maze/index.md Outdated Show resolved Hide resolved
recipes/expressive-react-maze/index.md Outdated Show resolved Hide resolved
recipes/expressive-react-maze/index.md Outdated Show resolved Hide resolved
recipes/expressive-react-maze/index.md Outdated Show resolved Hide resolved
recipes/expressive-react-maze/index.md Outdated Show resolved Hide resolved
recipes/expressive-react-maze/index.md Outdated Show resolved Hide resolved
@HellSquirrel
Copy link
Member Author

Пунктуация сложно :) Спасибо <3

@TatianaFokina
Copy link
Member

Пунктуация сложно :) Спасибо <3

Не факт, что я её осилила 😅

@HellSquirrel @TatianaFokina
Уважает запятые
bf0231a 
Co-authored-by: Tatiana Fokina <fokinatatian@gmail.com>
@HellSquirrel
Copy link
Member Author

Не факт, что я её осилила 😅

Факт что я ее точно не осилила :)

@github-actions GitHub Actions
Copy link

Превью контента из bf0231a опубликовано.

@HellSquirrel HellSquirrel merged commit 5c76691 into main Apr 12, 2024
6 checks passed
@HellSquirrel HellSquirrel deleted the recipe/expressive-react-2-maze branch April 12, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitya-ne vitya-ne vitya-ne approved these changes

@TatianaFokina TatianaFokina TatianaFokina approved these changes

@solarrust solarrust Awaiting requested review from solarrust solarrust is a code owner

@skorobaeus skorobaeus Awaiting requested review from skorobaeus

Assignees

@HellSquirrel HellSquirrel

Labels
рецепт Контент для Рецептов статья Расширенный материал
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HellSquirrel @solarrust @vitya-ne @TatianaFokina