Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dokan_fuse: Ship pkg-config file #338

Closed
Rondom opened this issue Sep 14, 2016 · 2 comments · Fixed by #375
Closed

dokan_fuse: Ship pkg-config file #338

Rondom opened this issue Sep 14, 2016 · 2 comments · Fixed by #375

Comments

@Rondom
Copy link
Contributor

Rondom commented Sep 14, 2016

We might want to ship a pkg-config file to simplify building against dokanfuse. At least during the cmake-install this is easy to accomplish.

http://www.kaizou.org/2014/11/typical-cmake-project/

I am not sure whether we can ship it with the installer, though. Reason: One can use pkg-config for compiling under Cygwin, MSYS or Windows. All three have different means of specifying the same path (C:\foo,/c/foo,/cygdrive/c/foo) and the LDFLAGS may also be different

@Rondom
Copy link
Contributor Author

Rondom commented Sep 25, 2016

The instructions in the link above can be simplified by not using so many custom variables (PKG_CONFIG_). For example one can reuse CMAKE_INSTALL_INCLUDEDIR instead of defining a separate custom variable PKG_CONFIG_INCLUDEDIR.

In my opinion, we should probably not use the fuse name for our pkg-config-file. There are several different user space file system solution and our solution is not the original libfuse. We should respect the original libfuse (unlikely they ever accept patches bringing Windows-compatibility, but still) and also avoid a conflict with any alternative user-space FS solutions. I would like to hear other people's opinions on this, though.

Rondom added a commit to Rondom/dokany that referenced this issue Oct 22, 2016
Generate a pkg-config-file that can be used as a drop-in "replacement"
for libfuse, i.e.
$ pkg-config --libs --cflags fuse
will return the dokanfuse-flags.

Closes dokan-dev#338.
Rondom added a commit to Rondom/dokany that referenced this issue Oct 25, 2016
Generate a pkg-config-file that can be used as a drop-in "replacement"
for libfuse, i.e.
$ pkg-config --libs --cflags fuse
will return the dokanfuse-flags.

Closes dokan-dev#338.
@Rondom
Copy link
Contributor Author

Rondom commented Oct 25, 2016

I opened PR #375.
It needs testing and some discussion about how to handle the fact that we are using the libfuse-name.

Rondom added a commit to Rondom/dokany that referenced this issue Oct 25, 2016
Generate a pkg-config-file that can be used as a drop-in "replacement"
for libfuse, i.e.
$ pkg-config --libs --cflags fuse
will return the dokanfuse-flags.

Closes dokan-dev#338.
Rondom added a commit to Rondom/dokany that referenced this issue Oct 26, 2016
Generate a pkg-config-file that can be used as a drop-in "replacement"
for libfuse, i.e.
$ pkg-config --libs --cflags fuse
will return the dokanfuse-flags.

Closes dokan-dev#338.
Rondom added a commit to Rondom/dokany that referenced this issue Oct 27, 2016
Generate a pkg-config-file that can be used as a drop-in "replacement"
for libfuse, i.e.
$ pkg-config --libs --cflags fuse
will return the dokanfuse-flags.

Closes dokan-dev#338.
Rondom added a commit to Rondom/dokany that referenced this issue Oct 27, 2016
Generate a pkg-config-file that can be used as a drop-in "replacement"
for libfuse, i.e.
$ pkg-config --libs --cflags fuse
will return the dokanfuse-flags.

Closes dokan-dev#338.
Rondom added a commit to Rondom/dokany that referenced this issue Oct 27, 2016
Generate a pkg-config-file that can be used as a drop-in "replacement"
for libfuse, i.e.
$ pkg-config --libs --cflags fuse
will return the dokanfuse-flags.

Closes dokan-dev#338.
Rondom added a commit to Rondom/dokany that referenced this issue Oct 27, 2016
Generate a pkg-config-file that can be used as a drop-in "replacement"
for libfuse, i.e.
$ pkg-config --libs --cflags fuse
will return the dokanfuse-flags.

Closes dokan-dev#338.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants