Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue with DokanUnmount() failing to unmount a drive #79

Merged
merged 4 commits into from
Oct 10, 2015

Conversation

Corillian
Copy link

This fix also applies to dokanctl.exe /u
Enabled debug information for dokan.dll and dokannp.dll when compiling
in Debug so that I could debug
Issue #57

This fix also applies to dokanctl.exe /u
Enabled debug information for dokan.dll and dokannp.dll when compiling
in Debug so that I could debug
@Liryna
Copy link
Member

Liryna commented Oct 1, 2015

Thanks for this PR ❤️ and taking the time in your issue :D !

To finish to normalizing mount paths, don't you think we should also change the mount function to force the M:\ ?
https://github.com/Corillian/dokany/blob/InvestigateHang/dokan_mount/mount.c#L263

And also fix the mirror 😄 https://github.com/Corillian/dokany/blob/InvestigateHang/dokan_mirror/mirror.c#L51

@Corillian
Copy link
Author

Hey sorry got sidetracked with working on other stuff. Yeah I can add normalization to mirror and mount.

@Corillian
Copy link
Author

Ok I added the normalization to mounter.exe as that seems to be the only place where it matters. Drive letter names are normalized to the format "C:" upon insertion into g_MountList as well as when g_MountList is being searched. I also updated this branch to the latest on master. Let me know if I missed anything.

@Liryna
Copy link
Member

Liryna commented Oct 9, 2015

Thank you @Corillian and for taking the time !
I will try to take a look this weekend :)

@Liryna
Copy link
Member

Liryna commented Oct 10, 2015

Perfectly working on my side after test !
Thank a lot @Corillian for your contributions in the dokan project !

Normalizing the mount point will help a lot the dev & users of dokan !

Liryna added a commit that referenced this pull request Oct 10, 2015
Fixed an issue with DokanUnmount() failing to unmount a drive
@Liryna Liryna merged commit d1c8a13 into dokan-dev:master Oct 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants