Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to skip restarts on link and unlink #27

Merged
merged 11 commits into from
Feb 25, 2023
Prev Previous commit
fix: update link docs to remove erroneous copy-paste
  • Loading branch information
Jose Diaz-Gonzalez committed Feb 25, 2023
commit 08e9a8dc6af8f9bfd67abbae52019f4e8bc119c6
10 changes: 2 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
@@ -212,7 +212,7 @@ DOKKU_PUSHPIN_LOLLIPOP_PORT_5561_TCP_ADDR=172.17.0.1
The following will be set on the linked application by default:

```
WEBSOCKET_URL=websocket://lollipop:SOME_PASSWORD@dokku-pushpin-lollipop:5561/lollipop
WEBSOCKET_URL=websocket://dokku-pushpin-lollipop:5561/lollipop
```

The host exposed here only works internally in docker containers. If you want your container to be reachable from outside, you should use the `expose` subcommand. Another service can be linked to your app:
@@ -231,13 +231,7 @@ dokku pushpin:link lollipop playground
This will cause `WEBSOCKET_URL` to be set as:

```
websocket2://lollipop:SOME_PASSWORD@dokku-pushpin-lollipop:5561/lollipop
```

If you specify `PUSHPIN_DATABASE_SCHEME` to equal `http`, we`ll also automatically adjust `WEBSOCKET_URL` to match the http interface:

```
http://lollipop:SOME_PASSWORD@dokku-pushpin-lollipop:${PLUGIN_DATASTORE_PORTS[1]}
websocket2://dokku-pushpin-lollipop:5561/lollipop
```

### unlink the pushpin service from the app
8 changes: 2 additions & 6 deletions subcommands/link
Original file line number Diff line number Diff line change
@@ -23,7 +23,7 @@ service-link-cmd() {
#E
#E the following will be set on the linked application by default:
#E
#E ${PLUGIN_DEFAULT_ALIAS}_URL=${PLUGIN_SCHEME}://lollipop:SOME_PASSWORD@dokku-${PLUGIN_COMMAND_PREFIX}-lollipop:${PLUGIN_DATASTORE_PORTS[0]}/lollipop
#E ${PLUGIN_DEFAULT_ALIAS}_URL=${PLUGIN_SCHEME}://dokku-${PLUGIN_COMMAND_PREFIX}-lollipop:${PLUGIN_DATASTORE_PORTS[0]}/lollipop
#E
#E the host exposed here only works internally in docker containers.
#E if you want your container to be reachable from outside, you should
@@ -37,11 +37,7 @@ service-link-cmd() {
#E dokku $PLUGIN_COMMAND_PREFIX:link lollipop playground
#E this will cause ${PLUGIN_DEFAULT_ALIAS}_URL to be set as:
#E
#E ${PLUGIN_SCHEME}2://lollipop:SOME_PASSWORD@dokku-${PLUGIN_COMMAND_PREFIX}-lollipop:${PLUGIN_DATASTORE_PORTS[0]}/lollipop
#E
#E If you specify ${PLUGIN_VARIABLE}_DATABASE_SCHEME to equal `http`, we'll also automatically adjust ${PLUGIN_DEFAULT_ALIAS}_URL to match the http interface:
#E
#E http://lollipop:SOME_PASSWORD@dokku-${PLUGIN_COMMAND_PREFIX}-lollipop:${PLUGIN_DATASTORE_PORTS[1]}
#E ${PLUGIN_SCHEME}2://dokku-${PLUGIN_COMMAND_PREFIX}-lollipop:${PLUGIN_DATASTORE_PORTS[0]}/lollipop
#A service, service to run command against
#A app, app to run command against
#F -a|--alias "BLUE_DATABASE", an alternative alias to use for linking to an app via environment variable