Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DIOS-6234: Update stats #203

Merged
merged 1 commit into from
Aug 2, 2024
Merged

DIOS-6234: Update stats #203

merged 1 commit into from
Aug 2, 2024

Conversation

sheiladoherty-dolby
Copy link
Contributor

  • Added stats exposed on the SDK to be in sync with what Android is displaying:
    • subscriberId
    • streamViewId
    • clusterId
    • outgoingBitrate
    • incomingBitrate
    • freezeCount
    • freezeDuration
    • pauseCount
    • pauseDuration
    • totalStreamTime
    • retransmittedPacketsReceived
    • retransmittedBytesReceived

aravind-raveendran
aravind-raveendran reviewed Aug 1, 2024
View reviewed changes
Copy link
Contributor

@aravind-raveendran aravind-raveendran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few minor questions

LocalPackages/RTSCore/Sources/RTSCore/Manager/SubscriptionManager.swift Show resolved Hide resolved
interactive-player/Interactive Viewer/Managers/VideoTracksManager.swift Outdated Show resolved Hide resolved
interactive-player/Interactive Viewer/Managers/VideoTracksManager.swift Show resolved Hide resolved
interactive-player/Interactive Viewer/Managers/VideoTracksManager.swift Outdated Show resolved Hide resolved
LocalPackages/RTSCore/Sources/RTSCore/Models/StreamStatistics.swift Outdated Show resolved Hide resolved
LocalPackages/RTSCore/Sources/RTSCore/Models/StreamStatistics.swift Show resolved Hide resolved
@sheiladoherty-dolby
streamViewId & subscriberId
95e03ab 
retransmission values

elapsed time

incoming & outgoing bitrates

PR updates

tvOS fixes

small fix

small fix
@sheiladoherty-dolby sheiladoherty-dolby merged commit 017fb3a into main Aug 2, 2024
2 checks passed
@sheiladoherty-dolby sheiladoherty-dolby deleted the feature/updateStats branch August 8, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Agustin-Bologna-Dolby Agustin-Bologna-Dolby Agustin-Bologna-Dolby approved these changes

@aravind-raveendran aravind-raveendran aravind-raveendran approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sheiladoherty-dolby @aravind-raveendran @Agustin-Bologna-Dolby