Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legolas - Tenants and Resources #589

Merged
merged 27 commits into from
Nov 18, 2021
Merged

Legolas - Tenants and Resources #589

merged 27 commits into from
Nov 18, 2021

Conversation

woksin
Copy link
Contributor

@woksin woksin commented Nov 9, 2021 •
edited by jakhog
Loading

Summary

Implements Contracts 6.3.0, which adds support for getting the configured Tenants, and connection string for a MongoDB resource per tenant. Note: this MongoDB connection string is configured through the "readModels" key in resources.json to be backwards compatible with the platform configuration.

Added

  • TenantsService: Getting all tenants through gRPC
  • ResourcesService: Getting a specific resource through gRPC. Currently only the MongoDB is supported through the readModels resource configuration

@woksin woksin added the minor label Nov 9, 2021
jakhog
jakhog reviewed Nov 15, 2021
View reviewed changes
Copy link
Contributor

@jakhog jakhog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments for myself to look closer at and try out. Will probably fix or ignore most of these myself :)

Source/Resources/MongoDB/Configuration.cs Outdated Show resolved Hide resolved
Source/Resources/MongoDB/ConnectionDetails.cs Outdated Show resolved Hide resolved
Source/Resources/MongoDB/IResource.cs Outdated Show resolved Hide resolved
Source/Resources/MongoDB/Resource.cs Outdated Show resolved Hide resolved
Source/Resources/MongoDB/ResourceType.cs Show resolved Hide resolved
Source/Resources/MongoDB/Service.cs Outdated Show resolved Hide resolved
Source/Server/.dolittle/bounded-context.json Outdated Show resolved Hide resolved
Source/Tenancy/LoggerExtensions.cs Outdated Show resolved Hide resolved
Source/Tenancy/Tenancy.csproj Outdated Show resolved Hide resolved
versions.props Outdated Show resolved Hide resolved
@jakhog jakhog marked this pull request as draft November 16, 2021 06:38
@jakhog jakhog changed the title New prerelease Legolas - Tenants and Resources Nov 18, 2021
@jakhog jakhog marked this pull request as ready for review November 18, 2021 14:27
@jakhog jakhog merged commit 82abce9 into master Nov 18, 2021
@jakhog jakhog deleted the 7.3.0-legolas branch November 18, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakhog jakhog jakhog left review comments

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woksin @jakhog