Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes a mem leak in AbstractScopedStreamProcessor #715

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Fixes a mem leak in AbstractScopedStreamProcessor #715

merged 1 commit into from
Oct 5, 2022

Conversation

mhelleborg
Copy link
Member

Fixed

  • Fixes a minor memory leak for scoped stream processors

@mhelleborg mhelleborg requested a review from woksin October 4, 2022 20:32
@woksin
Copy link
Contributor

woksin commented Oct 4, 2022

Won't Dispose be called on it either way in the outermost finally-block?

@mhelleborg mhelleborg changed the title Fixes a mem leak in AbstractScopedStreamProcessor caused by a missing dispose Fixes a mem leak in AbstractScopedStreamProcessor Oct 5, 2022
@mhelleborg
Copy link
Member Author

Won't Dispose be called on it either way in the outermost finally-block?

It creates new instances in the inner loop, which needs to be disposed too. This was missing before

@woksin woksin merged commit 278f839 into master Oct 5, 2022
@woksin woksin deleted the plug branch October 5, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woksin woksin woksin approved these changes

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhelleborg @woksin