Fix incomplete support for interface encoding/binary.AppendByteOrder #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test pass on the supported architectures, but should fail on unknown architectures (handled by others.go).
Unknown architectures (where byte order is determined at runtime) get support of AppendByteOrder interface (added in Go 1.19) in addition to ByteOrder interface.
dolmen
force-pushed
the
AppendByteOrder
branch
from
7c866fc
to
428c603
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should compile:
However it didn't for "unknown" architectures (those unknown at code generation time).
This fixes
others.goand addsothers_go1.19.goto handle the go1.19+ features (binary.AppendByteOrder).