Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS Windows support #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

OS Windows support #5

wants to merge 1 commit into from

Conversation

mukexa
Copy link

@mukexa mukexa commented Jan 20, 2020

No description provided.

@codecov-io
Copy link

codecov-io commented Jan 20, 2020

Codecov Report

Merging #5 into master will decrease coverage by 0.2%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
- Coverage   52.59%   52.39%   -0.21%     
==========================================
  Files           6        6              
  Lines         521      523       +2     
==========================================
  Hits          274      274              
- Misses        181      182       +1     
- Partials       66       67       +1
Impacted Files Coverage Δ
resolvepath.go 53.84% <0%> (-4.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1f1850...0ef389d. Read the comment docs.

@dolmen
Copy link
Member

dolmen commented Mar 11, 2021

Could you describe the problem with the input files and the error reported?

Anyway, patching the resolvePath function with reference to runtime.GOOS doesn't feel right. OS-related issues in filepath handling should happen more around calls to the loadFile function.

@dolmen dolmen added the help wanted Extra attention is needed label Mar 11, 2021
@mukexa
Copy link
Author

mukexa commented Mar 22, 2021

(google translate)
Sorry for not describing the problem right away.
I don't work with Golang right now.
If I remember correctly...
The problem is the following, Windows does not use a slash at the beginning of the path.
c:/user
not
/c:/user

@dolmen
Copy link
Member

dolmen commented Jun 2, 2022

@mukexa Thanks for the feedback. That's helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants